source/tests/infer/test_models.py (1)

42-45: Prefer deriving the pt_expt skip from fixture metadata.

The hard-coded ("se_e2_a", "se_e2_r") list will stay stale the next time a fixture is made exportable. The fixture already carries model_def_script.descriptor.type_one_side, so reading the skip condition from case would keep this gate aligned with the actual model data instead of the testcase key.

♻️ Suggested refactor

     `@classmethod`
     def setUpClass(cls) -> None:
         key, extension = cls.param
         if extension in (".pte", ".pt2") and not INSTALLED_PT_EXPT:
             raise unittest.SkipTest("pt_expt backend not installed")
-        if key in ("se_e2_a", "se_e2_r") and extension in (".pte", ".pt2"):
+        case = get_cases()[key]
+        descriptor = (case.model_def_script or {}).get("descriptor", {})
+        if (
+            extension in (".pte", ".pt2")
+            and descriptor.get("type") in {"se_e2_a", "se_e2_r"}
+            and not descriptor.get("type_one_side", False)
+        ):
             raise unittest.SkipTest(
                 "type_one_side=False is not supported for pt_expt export"
             )
         if key == "se_e2_r" and extension == ".pth":
             raise unittest.SkipTest(
                 "se_e2_r type_one_side is not supported for PyTorch models"
             )
-        cls.case = get_cases()[key]
+        cls.case = case

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@source/tests/infer/test_models.py` around lines 42 - 45, Replace the
hard-coded key check with a metadata-driven condition: instead of testing if key
in ("se_e2_a", "se_e2_r"), read the fixture's descriptor via the test case
(e.g., case.model_def_script.descriptor.type_one_side) and if that value is
False and extension is in (".pte", ".pt2") raise unittest.SkipTest; update the
conditional that currently uses variables key and extension to use
case.model_def_script.descriptor.type_one_side for the gate so the skip stays in
sync with fixture metadata.